changeset 2455:b6e215ab7552 draft

Document why we don't send both FQDN and hostname options.
author Roy Marples <roy@marples.name>
date Fri, 02 May 2014 06:40:21 +0000
parents 5d965f193b71
children ef4a50a6763f
files dhcp.c
diffstat 1 files changed, 9 insertions(+), 0 deletions(-) [+]
line wrap: on
line diff
--- a/dhcp.c	Wed Apr 30 14:14:03 2014 +0000
+++ b/dhcp.c	Fri May 02 06:40:21 2014 +0000
@@ -828,6 +828,15 @@
 			    ifo->options & DHCPCD_HOSTNAME_SHORT ? 1 : 0);
 		else
 			hostname = ifo->hostname;
+
+		/*
+		 * RFC4702 3.1 States that if we send the Client FQDN option
+		 * then we MUST NOT also send the Host Name option.
+		 * Technically we could, but that is not RFC conformant and
+		 * also seems to break some DHCP server implemetations such as
+		 * Windows. On the other hand, ISC dhcpd is just as non RFC
+		 * conformant by not accepting a partially qualified FQDN.
+		 */
 		if (ifo->fqdn != FQDN_DISABLE) {
 			/* IETF DHC-FQDN option (81), RFC4702 */
 			*p++ = DHO_FQDN;