Mercurial > hg > dhcpcd
changeset 4465:84ee61f7988b draft
auth: Improve comment about DHCPv4 option splitting not working
Patches to fix this welcome :)
| author | Roy Marples <roy@marples.name> |
|---|---|
| date | Sat, 20 Apr 2019 21:07:16 +0100 |
| parents | d5a636216f97 |
| children | bbc28f477a10 |
| files | src/auth.c |
| diffstat | 1 files changed, 5 insertions(+), 1 deletions(-) [+] |
line wrap: on
line diff
--- a/src/auth.c Sat Apr 20 21:03:21 2019 +0100 +++ b/src/auth.c Sat Apr 20 21:07:16 2019 +0100 @@ -117,7 +117,11 @@ m = vm; data = vdata; - /* Ensure that d is inside m which *may* not be the case for DHPCPv4 */ + /* Ensure that d is inside m which *may* not be the case for DHCPv4. + * This can occur if the authentication option is split using + * DHCP long option from RFC 3399. Section 9 which does infact note that + * implementations should take this into account. + * Fixing this would be problematic, patches welcome. */ if (data < m || data > m + mlen || data + dlen > m + mlen) { errno = ERANGE; return NULL;