changeset 299:3861aae6c690 draft

Prefer for (;;) over while (1)
author Roy Marples <roy@marples.name>
date Mon, 21 Jan 2008 16:08:42 +0000
parents d73dd36a3948
children bd43831eb570
files arp.c client.c interface.c ipv4ll.c
diffstat 4 files changed, 5 insertions(+), 5 deletions(-) [+]
line wrap: on
line diff
--- a/arp.c	Mon Jan 21 15:13:59 2008 +0000
+++ b/arp.c	Mon Jan 21 16:08:42 2008 +0000
@@ -141,7 +141,7 @@
 	buffer = xmalloc (iface->buffer_length);
 	reply = xmalloc (iface->buffer_length);
 
-	while (1) {
+	for (;;) {
 		struct timeval tv;
 		int bufpos = -1;
 		int buflen = iface->buffer_length;
--- a/client.c	Mon Jan 21 15:13:59 2008 +0000
+++ b/client.c	Mon Jan 21 16:08:42 2008 +0000
@@ -999,7 +999,7 @@
 
 	signal_setup ();
 
-	while (1) {
+	for (;;) {
 		retval = wait_for_packet (&rset, state, options);
 
 		/* We should always handle our signals first */
--- a/interface.c	Mon Jan 21 15:13:59 2008 +0000
+++ b/interface.c	Mon Jan 21 16:08:42 2008 +0000
@@ -171,7 +171,7 @@
 	/* Not all implementations return the needed buffer size for
 	 * SIOGIFCONF so we loop like so for all until it works */
 	memset (&ifc, 0, sizeof (struct ifconf));
-	while (1) {
+	for (;;) {
 		ifc.ifc_len = len;
 		ifc.ifc_buf = xmalloc (len);
 		if (ioctl (s, SIOCGIFCONF, &ifc) == -1) {
@@ -715,7 +715,7 @@
 	memset (buffer, 0, BUFFERLEN);
 	iov.iov_base = buffer;
 
-	while (1) {
+	for (;;) {
 		iov.iov_len = BUFFERLEN;
 		bytes = recvmsg (s, &msg, 0);
 
--- a/ipv4ll.c	Mon Jan 21 15:13:59 2008 +0000
+++ b/ipv4ll.c	Mon Jan 21 16:08:42 2008 +0000
@@ -43,7 +43,7 @@
 int ipv4ll_get_address (interface_t *iface, dhcp_t *dhcp) {
 	struct in_addr addr;
 
-	while (1) {
+	for (;;) {
 		addr.s_addr = htonl (LINKLOCAL_ADDR |
 				     ((abs (random ()) % 0xFD00) + 0x0100));
 		errno = 0;