changeset 5240:0281af78918f draft

privsep: Add comment about BPF returing EPERM on OpenBSD. Looks like an OpenBSD bug.
author Roy Marples <roy@marples.name>
date Wed, 20 May 2020 14:15:30 +0100
parents 4507bcbe200d
children 989bcc6c8e70
files src/privsep-bpf.c
diffstat 1 files changed, 7 insertions(+), 0 deletions(-) [+]
line wrap: on
line diff
--- a/src/privsep-bpf.c	Wed May 20 14:07:36 2020 +0100
+++ b/src/privsep-bpf.c	Wed May 20 14:15:30 2020 +0100
@@ -106,6 +106,13 @@
 {
 	struct ps_process *psp = arg;
 
+	/*
+	 * OpenBSD-6.6 at least will return EPERM here for every
+	 * BOOTP sent except for the first one.
+	 * However with wih EPERM, the BOOTP message is *still* sent.
+	 * This means the BPF write filter isn't working as it should.
+	 * On FreeBSD it works fine.
+	 */
 	if (ps_recvpsmsg(psp->psp_ctx, psp->psp_fd,
 	    ps_bpf_recvmsgcb, arg) == -1)
 		logerr(__func__);