# HG changeset patch # User Roy Marples # Date 1600807993 -3600 # Node ID 4f7691185a753d883f3f485e9bb2a83a42a49e43 # Parent 8dcd62252f2dc72aee176f2b916c910df20756fb BSD: Use SIOCGIFDATA if no media support and no ifa_data Hopefully this nails link state once and for all on BSD. diff -r 8dcd62252f2d -r 4f7691185a75 src/if-bsd.c --- a/src/if-bsd.c Tue Sep 22 13:09:03 2020 +0100 +++ b/src/if-bsd.c Tue Sep 22 21:53:13 2020 +0100 @@ -359,8 +359,8 @@ #endif } -int -if_carrier(struct interface *ifp) +static int +if_carrier0(struct interface *ifp) { struct ifmediareq ifmr = { .ifm_status = 0 }; @@ -379,9 +379,33 @@ } int +if_carrier(struct interface *ifp) +{ + int carrier = if_carrier0(ifp); + struct ifdatareq ifdr = { .ifdr_data.ifi_link_state = 0 }; + struct if_data *ifdata; + + if (carrier != LINK_UNKNOWN) + return carrier; + + strlcpy(ifdr.ifdr_name, ifp->name, sizeof(ifdr.ifdr_name)); + if (ioctl(ifp->ctx->pf_inet_fd, SIOCGIFDATA, &ifdr) == -1) + return LINK_UNKNOWN; + + ifdata = &ifdr.ifdr_data; + switch (ifdata->ifi_link_state) { + case LINK_STATE_DOWN: + return LINK_DOWN; + case LINK_STATE_UP: + return LINK_UP; + } + return LINK_UNKNOWN; +} + +int if_carrier_ifadata(struct interface *ifp, void *ifadata) { - int carrier = if_carrier(ifp); + int carrier = if_carrier0(ifp); struct if_data *ifdata; if (carrier != LINK_UNKNOWN || ifadata == NULL)