dhcpcd
8 weeks agoFreeBSD: Finish EVFILT_PROCDESC implementation. master
Roy Marples [Thu, 18 Mar 2021 12:14:54 +0000 (12:14 +0000)]
FreeBSD: Finish EVFILT_PROCDESC implementation.

8 weeks agoFix more new eloop fallout.
Roy Marples [Wed, 17 Mar 2021 20:16:20 +0000 (20:16 +0000)]
Fix more new eloop fallout.

8 weeks agoprivsep: Implement pdfork(2) for capsicum(4)
Roy Marples [Wed, 17 Mar 2021 20:13:02 +0000 (20:13 +0000)]
privsep: Implement pdfork(2) for capsicum(4)

Capsicum does not allow waitpid(2).
As such we need to use pdfork(2) and watch for the descriptor to
hangup.

8 weeks agoprivsep: Fix FreeBSD for prior
Roy Marples [Wed, 17 Mar 2021 15:19:27 +0000 (15:19 +0000)]
privsep: Fix FreeBSD for prior

8 weeks agoprivsep: Fix Linux support for prior
Roy Marples [Wed, 17 Mar 2021 15:12:22 +0000 (15:12 +0000)]
privsep: Fix Linux support for prior

8 weeks agoprivsep: Remove debug from prior
Roy Marples [Wed, 17 Mar 2021 15:11:53 +0000 (15:11 +0000)]
privsep: Remove debug from prior

8 weeks agoprivsep: Implement some process management
Roy Marples [Wed, 17 Mar 2021 15:03:52 +0000 (15:03 +0000)]
privsep: Implement some process management

This also allows us to wait until all processes have exited to
avoid a fast restart which complains addresses are in use.

8 weeks agoprivsep: Don't close control proxy on hangup
Roy Marples [Wed, 17 Mar 2021 14:23:55 +0000 (14:23 +0000)]
privsep: Don't close control proxy on hangup

Instead wait for it to be closed by the master process for a
clean shtudown.

2 months agocontrol: Fix working with new eloop
Roy Marples [Wed, 10 Mar 2021 13:09:39 +0000 (13:09 +0000)]
control: Fix working with new eloop

2 months agosrc/privsep-linux.c: add support for m68k (#29)
Fabrice Fontaine [Mon, 8 Mar 2021 10:05:16 +0000 (11:05 +0100)]
src/privsep-linux.c: add support for m68k (#29)

Fix the following build failure:

privsep-linux.c:206:4: error: #error "Platform does not support seccomp filter yet"
 #  error "Platform does not support seccomp filter yet"
    ^~~~~
In file included from privsep-linux.c:36:
privsep-linux.c:213:38: error: 'SECCOMP_AUDIT_ARCH' undeclared here (not in a function); did you mean 'SECCOMP_ALLOW_ARG'?
  BPF_JUMP(BPF_JMP + BPF_JEQ + BPF_K, SECCOMP_AUDIT_ARCH, 1, 0),
                                      ^~~~~~~~~~~~~~~~~~

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
2 months agoREADME.md: remove dead reference to phabricator
Roy Marples [Mon, 8 Mar 2021 09:43:50 +0000 (09:43 +0000)]
README.md: remove dead reference to phabricator

2 months agocontrol: Cannot write with hangup
Roy Marples [Sat, 20 Feb 2021 16:25:05 +0000 (16:25 +0000)]
control: Cannot write with hangup

2 months agoeloop: delete events from kqueue/epoll directly
Roy Marples [Tue, 16 Feb 2021 16:43:18 +0000 (16:43 +0000)]
eloop: delete events from kqueue/epoll directly

Rather than relying on close(2) being called.
Whilst a bit less performant with many open/close, there is also
no guarantee that close(2) will actually be called as
shutdown(2) could be used instead.

2 months agolog a diagnostic here
Roy Marples [Tue, 16 Feb 2021 16:40:35 +0000 (16:40 +0000)]
log a diagnostic here

3 months agocontrol: Don't log error deleting fds from eloop.
Roy Marples [Tue, 9 Feb 2021 11:36:07 +0000 (11:36 +0000)]
control: Don't log error deleting fds from eloop.

They might not be added as they are inactive and its just noise
as no operation is done anymore even for kqueue or epoll.

3 months agoBSD: Find the correct interface for tunneled routes
Roy Marples [Tue, 9 Feb 2021 10:11:54 +0000 (10:11 +0000)]
BSD: Find the correct interface for tunneled routes

Should disard a harmless diagnostic.

3 months agocontrol: GC control deletion
Roy Marples [Mon, 8 Feb 2021 19:25:08 +0000 (19:25 +0000)]
control: GC control deletion

Just free it entirely.

3 months agosrc/privsep-linux.c: add support for arc (#28)
Fabrice Fontaine [Mon, 8 Feb 2021 06:23:54 +0000 (07:23 +0100)]
src/privsep-linux.c: add support for arc (#28)

Fix the following build failure:

privsep-linux.c:206:4: error: #error "Platform does not support seccomp filter yet"
 #  error "Platform does not support seccomp filter yet"
    ^~~~~
In file included from privsep-linux.c:36:
privsep-linux.c:213:38: error: 'SECCOMP_AUDIT_ARCH' undeclared here (not in a function); did you mean 'SECCOMP_ALLOW_ARG'?
  BPF_JUMP(BPF_JMP + BPF_JEQ + BPF_K, SECCOMP_AUDIT_ARCH, 1, 0),
                                      ^~~~~~~~~~~~~~~~~~

It should be noted that AUDIT_ARCH_{ARCOMPACT,ARCV2} is only defined
since kernel 5.2 and
https://github.com/torvalds/linux/commit/67f2a8a29311841ba6ab9b0e2d1b8f1e9978cd84

Detection of arc compact and arc v2 have been "copy/pasted" from
https://github.com/wbx-github/uclibc-ng/commit/afab56958f1cbb47b831ee3ebff231dfbae74af2

Fixes:
 - http://autobuild.buildroot.org/results/d29083700a80dd647621eed06faeeae03f0587d3

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
3 months agosrc/privsep-linux.c: add support for or1k (#27)
Fabrice Fontaine [Sun, 7 Feb 2021 08:43:14 +0000 (09:43 +0100)]
src/privsep-linux.c: add support for or1k (#27)

Fix the following build failure:

privsep-linux.c:206:4: error: #error "Platform does not support seccomp filter yet"
 #  error "Platform does not support seccomp filter yet"
    ^~~~~
In file included from privsep-linux.c:36:
privsep-linux.c:213:38: error: 'SECCOMP_AUDIT_ARCH' undeclared here (not in a function); did you mean 'SECCOMP_ALLOW_ARG'?
  BPF_JUMP(BPF_JMP + BPF_JEQ + BPF_K, SECCOMP_AUDIT_ARCH, 1, 0),
                                      ^~~~~~~~~~~~~~~~~~

It should be noted that AUDIT_ARCH_OPENRISC is defined since kernel 3.7:
https://github.com/torvalds/linux/commit/e2bebb4ae6d9ac4ffc524db67f7ecb205a173f77

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
3 months agoForce TOP as we know which directory we are in.
Roy Marples [Fri, 5 Feb 2021 22:41:16 +0000 (22:41 +0000)]
Force TOP as we know which directory we are in.

3 months agocontrol fd can be both read and write.
Roy Marples [Fri, 5 Feb 2021 21:56:40 +0000 (21:56 +0000)]
control fd can be both read and write.

3 months agosrc/privsep-linux: fix build on sparc (#26)
Fabrice Fontaine [Fri, 5 Feb 2021 08:25:12 +0000 (09:25 +0100)]
src/privsep-linux: fix build on sparc (#26)

Fix the following build failure:

privsep-linux.c:203: warning: "AUDIT_ARCH_SPARC64" redefined
  203 | #    define AUDIT_ARCH_SPARC64
      |
In file included from privsep-linux.c:35:
/srv/storage/autobuild/run/instance-0/output-1/host/sparc64-buildroot-linux-gnu/sysroot/usr/include/linux/audit.h:392: note: this is the location of the previous definition
  392 | #define AUDIT_ARCH_SPARC64 (EM_SPARCV9|__AUDIT_ARCH_64BIT)
      |
In file included from privsep-linux.c:36:
privsep-linux.c:215:38: error: 'SECCOMP_AUDIT_ARCH' undeclared here (not in a function); did you mean 'SECCOMP_ALLOW_ARG'?
  215 |  BPF_JUMP(BPF_JMP + BPF_JEQ + BPF_K, SECCOMP_AUDIT_ARCH, 1, 0),
      |                                      ^~~~~~~~~~~~~~~~~~

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
3 months agosrc/privsep-linux.c: add support for sh (#25)
Fabrice Fontaine [Fri, 5 Feb 2021 08:05:54 +0000 (09:05 +0100)]
src/privsep-linux.c: add support for sh (#25)

Fix the following build failure:

privsep-linux.c:206:4: error: #error "Platform does not support seccomp filter yet"
 #  error "Platform does not support seccomp filter yet"
    ^~~~~
In file included from privsep-linux.c:36:
privsep-linux.c:213:38: error: 'SECCOMP_AUDIT_ARCH' undeclared here (not in a function); did you mean 'SECCOMP_ALLOW_ARG'?
  BPF_JUMP(BPF_JMP + BPF_JEQ + BPF_K, SECCOMP_AUDIT_ARCH, 1, 0),
                                      ^~~~~~~~~~~~~~~~~~

It should be noted that AUDIT_ARCH_{SH,SHEL,SH64,SHEL64} are defined at
least since kernel 3.7 and
https://github.com/torvalds/linux/commit/607ca46e97a1b6594b29647d98a32d545c24bdff

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
3 months agoFix tests
Roy Marples [Wed, 3 Feb 2021 20:52:01 +0000 (20:52 +0000)]
Fix tests

3 months agoRename Privileged Actioneer to Privileged Proxy
Roy Marples [Tue, 2 Feb 2021 17:09:25 +0000 (17:09 +0000)]
Rename Privileged Actioneer to Privileged Proxy

Sadly actioneer is not a real word.

3 months agoRename Master to Manager
Roy Marples [Tue, 2 Feb 2021 16:54:09 +0000 (16:54 +0000)]
Rename Master to Manager

3 months agoFix prior for epoll.
Roy Marples [Tue, 2 Feb 2021 15:10:20 +0000 (15:10 +0000)]
Fix prior for epoll.

3 months agoeloop: Make the API more like native poll/kqueue/epoll
Roy Marples [Tue, 2 Feb 2021 14:41:54 +0000 (14:41 +0000)]
eloop: Make the API more like native poll/kqueue/epoll

Just have the one callback, but return an abstracted event mask
to work out if we can read/write have something else.
Log diagnostics if the event mask is unexpected.

While here add more logging if we fail to register an event to
monitor.

3 months agoAdd __NR_pselect6_time64 to priory
Roy Marples [Sun, 31 Jan 2021 21:12:26 +0000 (21:12 +0000)]
Add __NR_pselect6_time64 to priory

3 months agoLinux: allow pselect(2) to work in SECCOMP
Roy Marples [Sun, 31 Jan 2021 21:07:43 +0000 (21:07 +0000)]
Linux: allow pselect(2) to work in SECCOMP

The default is ppoll(2), but we still allow epoll(7) so
allowing pselect(2) makes perfect sense and allows the user
to pick the polling mechanism they want.

3 months ago src/privsep-linux.c: add support for microblaze (#24)
Fabrice Fontaine [Sun, 31 Jan 2021 20:57:40 +0000 (21:57 +0100)]
 src/privsep-linux.c: add support for microblaze (#24)

Fix the following build failure:

privsep-linux.c:206:4: error: #error "Platform does not support seccomp filter yet"
 #  error "Platform does not support seccomp filter yet"
    ^~~~~
In file included from privsep-linux.c:36:
privsep-linux.c:213:38: error: 'SECCOMP_AUDIT_ARCH' undeclared here (not in a function); did you mean 'SECCOMP_ALLOW_ARG'?
  BPF_JUMP(BPF_JMP + BPF_JEQ + BPF_K, SECCOMP_AUDIT_ARCH, 1, 0),
                                      ^~~~~~~~~~~~~~~~~~

It should be noted that AUDIT_ARCH_MICROBLAZE is only defined since
kernel 3.18 and
https://github.com/torvalds/linux/commit/ce5d112827e5c2e9864323d0efd7ec2a62c6dce0

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
3 months agoA belated welcome to 2021
Roy Marples [Sun, 31 Jan 2021 10:33:21 +0000 (10:33 +0000)]
A belated welcome to 2021

3 months ago src/privsep-linux.c: add support for nios2 (#23)
Fabrice Fontaine [Sun, 31 Jan 2021 10:12:21 +0000 (11:12 +0100)]
 src/privsep-linux.c: add support for nios2 (#23)

Fix the following build failure:

privsep-linux.c:206:4: error: #error "Platform does not support seccomp filter yet"
 #  error "Platform does not support seccomp filter yet"
    ^~~~~
In file included from privsep-linux.c:36:
privsep-linux.c:213:38: error: 'SECCOMP_AUDIT_ARCH' undeclared here (not in a function); did you mean 'SECCOMP_ALLOW_ARG'?
  BPF_JUMP(BPF_JMP + BPF_JEQ + BPF_K, SECCOMP_AUDIT_ARCH, 1, 0),
                                      ^~~~~~~~~~~~~~~~~~

It should be noted that AUDIT_ARCH_NIOS2 is only defined since kernel
5.2 and
https://github.com/torvalds/linux/commit/1660aac45e5b49a5ace29fb5b73254617533fcbd

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
3 months agoTypo with prior
Roy Marples [Sun, 31 Jan 2021 10:08:11 +0000 (10:08 +0000)]
Typo with prior

3 months agoLinux: Add support for NDS32BE SECCOMP
Roy Marples [Sun, 31 Jan 2021 07:37:03 +0000 (07:37 +0000)]
Linux: Add support for NDS32BE SECCOMP

3 months ago src/privsep-linux.c: add support for xtensa (#22)
Fabrice Fontaine [Sun, 31 Jan 2021 02:35:10 +0000 (03:35 +0100)]
 src/privsep-linux.c: add support for xtensa (#22)

Fix the following build failure:

privsep-linux.c:206:4: error: #error "Platform does not support seccomp filter yet"
 #  error "Platform does not support seccomp filter yet"
    ^~~~~
In file included from privsep-linux.c:36:
privsep-linux.c:213:38: error: 'SECCOMP_AUDIT_ARCH' undeclared here (not in a function); did you mean 'SECCOMP_ALLOW_ARG'?
  BPF_JUMP(BPF_JMP + BPF_JEQ + BPF_K, SECCOMP_AUDIT_ARCH, 1, 0),
                                      ^~~~~~~~~~~~~~~~~~

It should be noted that AUDIT_ARCH_XTENSA is only defined since kernel
5.0 and
https://github.com/torvalds/linux/commit/98c3115a4ec56f03056efd9295e0fcb4c5c57a85

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
3 months agoimport-src: Improve target so we don't create empty files
Roy Marples [Sat, 30 Jan 2021 12:21:15 +0000 (12:21 +0000)]
import-src: Improve target so we don't create empty files

3 months agoimport-src: adjust build target so all .in files are pre-built
Roy Marples [Sat, 30 Jan 2021 11:46:06 +0000 (11:46 +0000)]
import-src: adjust build target so all .in files are pre-built

While here, if we cannot find ypbind to work out how the hook script
should be configured, guess according to OS.

3 months agosrc/privsep-linux.c: add support for nds32 (#21)
Fabrice Fontaine [Sat, 30 Jan 2021 11:10:08 +0000 (12:10 +0100)]
src/privsep-linux.c: add support for nds32 (#21)

Fix the following build failure:

privsep-linux.c:206:4: error: #error "Platform does not support seccomp filter yet"
 #  error "Platform does not support seccomp filter yet"
    ^~~~~
In file included from privsep-linux.c:36:
privsep-linux.c:213:38: error: 'SECCOMP_AUDIT_ARCH' undeclared here (not in a function); did you mean 'SECCOMP_ALLOW_ARG'?
  BPF_JUMP(BPF_JMP + BPF_JEQ + BPF_K, SECCOMP_AUDIT_ARCH, 1, 0),
                                      ^~~~~~~~~~~~~~~~~~

It should be noted that AUDIT_ARCH_NDS32 is only defined since kernel
5.2 and
https://github.com/torvalds/linux/commit/fa562447e154334523daa44c0b60625d71a345f5

Fixes:
 - http://autobuild.buildroot.org/results/af8ba07ea0c12ab8cd24d528ef98db05521f3d36

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
3 months agoeloop: optimise the pselect code so it's not a wrapper for ppoll
Roy Marples [Sat, 30 Jan 2021 11:04:53 +0000 (11:04 +0000)]
eloop: optimise the pselect code so it's not a wrapper for ppoll

This makes the code smaller yet and also use less memory then ppoll!
Still, the API blows chunks and we still have arbitary fd limits
which we'll realistically never hit.
Also, some BSD's note potential issues with select on the same fd
across processes so ppoll is still the winner.

3 months agoeloop: Default to using ppoll(2) again.
Roy Marples [Sat, 30 Jan 2021 01:37:15 +0000 (01:37 +0000)]
eloop: Default to using ppoll(2) again.

Even though we now have fully working kqueue(2) and epoll(7)
with our privsep code, ppoll(2) is faster and smaller for our
workload.

This time though, we will keep the code here as it's fully working
and while fixing kqueue we also fixed other bugs in dhcpcd as a result
so it's not time wasted at all.

3 months agoeloop: Fix logic error with epoll reading test
Roy Marples [Fri, 29 Jan 2021 22:10:21 +0000 (01:10 +0300)]
eloop: Fix logic error with epoll reading test

3 months agoeloop: Always free the pollfd buffer when clearing events
Roy Marples [Fri, 29 Jan 2021 11:13:43 +0000 (11:13 +0000)]
eloop: Always free the pollfd buffer when clearing events

And set the flag to re-create it before the next run.
This allows us to always ensure it's small if the prior run
used more signals and fds.

3 months agoeloop: fix a memory leak when clearing events
Roy Marples [Fri, 29 Jan 2021 06:48:17 +0000 (06:48 +0000)]
eloop: fix a memory leak when clearing events

3 months agoWhitespace
Roy Marples [Fri, 29 Jan 2021 06:46:39 +0000 (06:46 +0000)]
Whitespace

3 months agoeloop: fixup a compile warning
Roy Marples [Thu, 28 Jan 2021 23:25:26 +0000 (23:25 +0000)]
eloop: fixup a compile warning

3 months agoBSD: Plug a memory leak
Roy Marples [Thu, 28 Jan 2021 23:24:49 +0000 (23:24 +0000)]
BSD: Plug a memory leak

3 months agoLinux: Implement epoll(7) for eloop (again)
Roy Marples [Thu, 28 Jan 2021 17:26:20 +0000 (17:26 +0000)]
Linux: Implement epoll(7) for eloop (again)

eloop allows for O(1) processing of active fd's.
The problems with the prior implementation have now been fixed.

3 months agocontrol: Don't log the write db didn't exist when freeing it.
Roy Marples [Thu, 28 Jan 2021 17:26:08 +0000 (17:26 +0000)]
control: Don't log the write db didn't exist when freeing it.

3 months agoprivsep: Restore the poll maxfd + 1 for state engine
Roy Marples [Thu, 28 Jan 2021 13:17:57 +0000 (13:17 +0000)]
privsep: Restore the poll maxfd + 1 for state engine

It wasn't fixed, it was using kqueue so avoided!

3 months agoDragonFly: cast away more kqueue compile warnings
Roy Marples [Thu, 28 Jan 2021 12:51:47 +0000 (12:51 +0000)]
DragonFly: cast away more kqueue compile warnings

3 months agoFreeBSD: cast away some kqueue warnings
Roy Marples [Thu, 28 Jan 2021 12:39:07 +0000 (12:39 +0000)]
FreeBSD: cast away some kqueue warnings

NetBSD uses size_t, FreeBSD uses int for changelist length.

3 months agoprivsep: Don't add 1 to max fd open when limiting resources
Roy Marples [Thu, 28 Jan 2021 12:13:45 +0000 (12:13 +0000)]
privsep: Don't add 1 to max fd open when limiting resources

It shoud no longer be needed for OpenBSD, Linux and Solaris.

3 months agoOpenBSD: Fix kqueue detection and one error.
Roy Marples [Thu, 28 Jan 2021 12:13:24 +0000 (12:13 +0000)]
OpenBSD: Fix kqueue detection and one error.

3 months agoBSD: Implement kqueue(2) for eloop (again)
Roy Marples [Thu, 28 Jan 2021 11:54:05 +0000 (11:54 +0000)]
BSD: Implement kqueue(2) for eloop (again)

kqueue allows for O(1) processing of active fd's an a more
robust signal handling method without the need to use global
variables to avoid calling functions during signal delivery.

The problems with the prior implemenation have now been fixed.

3 months agoprivsep: move setting signals to after clearing eloop
Roy Marples [Wed, 27 Jan 2021 14:11:52 +0000 (14:11 +0000)]
privsep: move setting signals to after clearing eloop

3 months agoWhitespace
Roy Marples [Wed, 27 Jan 2021 13:45:34 +0000 (13:45 +0000)]
Whitespace

3 months agoprivsep: Ensure BPF listener pid is logged in debug
Roy Marples [Wed, 27 Jan 2021 13:37:31 +0000 (13:37 +0000)]
privsep: Ensure BPF listener pid is logged in debug

This mirrors the inet listener.

3 months agocontrol: log an error if we fail to remove the write callback
Roy Marples [Wed, 27 Jan 2021 13:33:52 +0000 (13:33 +0000)]
control: log an error if we fail to remove the write callback

3 months agoWhitespace
Roy Marples [Wed, 27 Jan 2021 13:31:51 +0000 (13:31 +0000)]
Whitespace

3 months agocontrol: unlink privileged socket when shutting down without privsep
Roy Marples [Tue, 26 Jan 2021 17:37:29 +0000 (17:37 +0000)]
control: unlink privileged socket when shutting down without privsep

Otherwise we have a connection refused when dhcpcd starts again
as it sees the stale socket file.

3 months agoLinux: fix a memory leak when dhcpcd exits or the log is reopened
Roy Marples [Sun, 24 Jan 2021 22:53:20 +0000 (22:53 +0000)]
Linux: fix a memory leak when dhcpcd exits or the log is reopened

3 months agoeloop: Allow eloop to process all fds returned from poll(2)
Roy Marples [Sun, 24 Jan 2021 22:22:25 +0000 (22:22 +0000)]
eloop: Allow eloop to process all fds returned from poll(2)

We do this by ensuring the events list or pollfd struct storage
is not modified during the revent processing.
An event with a fd of -1 means it's been deleted and one without
a pollfd struct reference has been newly added.
This also allows us to count down the number of fd's that
returned a revent so we can break the loop early if possible.

This is a really minor optimisation that at best only applies if
more than one revent is returned via poll(2).
In the case on dhcpcd on NetBSD with privsep, the number of
fd's is really low. And on other platforms or without privsep it's
low also (just not as low).
It's only when you run dhcpcd per interface that the number
of fd's starts to creep upwards as you then need one per address
dhcpcd is monitoring (as well as the ARP listener per IPv4 address
for non NetBSD).

However, I use eloop in other code where this could be a good saving
and dhcpcd is where the master version of this lives!

3 months agoscript: Use rt_proto_add to ensure no duplicate interfaces on OpenBSD
Roy Marples [Mon, 18 Jan 2021 11:31:05 +0000 (11:31 +0000)]
script: Use rt_proto_add to ensure no duplicate interfaces on OpenBSD

OpenBSD allows matching priorities, so we need to take the interfaces
in the order given to ensure uniqueness.

4 months agoRelease dhcpcd-9.4.0 dhcpcd-9.4.0
Roy Marples [Mon, 28 Dec 2020 12:59:20 +0000 (12:59 +0000)]
Release dhcpcd-9.4.0

4 months agoscript: ignore inactive interfaces for ordering
Roy Marples [Mon, 28 Dec 2020 01:59:57 +0000 (01:59 +0000)]
script: ignore inactive interfaces for ordering

4 months agoDHCP: Split hardware address randomisation out of anonymous option
Roy Marples [Mon, 28 Dec 2020 00:02:26 +0000 (00:02 +0000)]
DHCP: Split hardware address randomisation out of anonymous option

A 3rd party might want to control the randomisation.

4 months agoDHCP: For anonymous, just use a generic clientid
Roy Marples [Sun, 27 Dec 2020 23:52:44 +0000 (23:52 +0000)]
DHCP: For anonymous, just use a generic clientid

4 months ago20-resolv.conf: Don't call resolvconf -c if we didn't call -C
Roy Marples [Sun, 27 Dec 2020 22:31:02 +0000 (22:31 +0000)]
20-resolv.conf: Don't call resolvconf -c if we didn't call -C

This solves the warnings on all OS other than Linux who don't have
a supporting resolvconf for deprecating DNS because they never
emit the NOCARRIER_ROAMING reason.

4 months agoCheck for NetBSD in prior, as we did before
Roy Marples [Sun, 27 Dec 2020 22:04:45 +0000 (22:04 +0000)]
Check for NetBSD in prior, as we did before

4 months agodhcpcd: Don't roam when anonymous is set
Roy Marples [Sun, 27 Dec 2020 21:59:32 +0000 (21:59 +0000)]
dhcpcd: Don't roam when anonymous is set

We can now remove the NOCARRIER_PRESERVE_IP define.

4 months agoNetBSD: Map IP Persistance to roaming
Roy Marples [Sun, 27 Dec 2020 20:39:38 +0000 (20:39 +0000)]
NetBSD: Map IP Persistance to roaming

We can use IN_IFF_TENTATIVE for this.

4 months agoAdjust prior to build routes and run script after aborting protocols for roaming
Roy Marples [Sun, 27 Dec 2020 20:39:31 +0000 (20:39 +0000)]
Adjust prior to build routes and run script after aborting protocols for roaming

4 months agohooks: add NOCARRIER_ROAMING reason
Roy Marples [Sun, 27 Dec 2020 19:53:31 +0000 (19:53 +0000)]
hooks: add NOCARRIER_ROAMING reason

This is given when the OS supports the concept of wireless roaming
or the IP setup can be persisted when the carrier drops.

When this happens, routes are moved to a higher metric (if supported)
to support non preferred but non roaming routes.
The `interface_order` hook variable will now order the interfaces
according to priority and move roaming interfaces to the back of the
list.
If resolvconf is present then it is called with the -C option
to deprecate DNS and if carrier comes back it is called again with the
-c option to activate it once more.

As part of this change, default route metrics have been changed to
support a larger number of interfaces.
base metric 1000 (was 200)
wireless offset 2000 (was 100)
IPv4LL offset 1000000 (was 10000)
roaming offset 2000000

4 months agosrc/dhcpcd.c: fix build without fork or signals (#20)
Fabrice Fontaine [Sat, 26 Dec 2020 19:45:08 +0000 (20:45 +0100)]
src/dhcpcd.c: fix build without fork or signals (#20)

Since version 9.3.3 and commit a5348dd02c86fa940cd93f203d0aa974cae0563c,
build without fork or signals fails on:

dhcpcd.c: In function ‘main’:
dhcpcd.c:2261:3: error: label ‘start_master’ used but not defined
   goto start_master;
   ^~~~

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
4 months agoprivsep: log sandbox when not daemonising
Roy Marples [Sat, 26 Dec 2020 15:58:46 +0000 (15:58 +0000)]
privsep: log sandbox when not daemonising

4 months agolinux: ARM64 stock kernel does not emit hardware in cpuinfo
Roy Marples [Sat, 26 Dec 2020 15:57:31 +0000 (15:57 +0000)]
linux: ARM64 stock kernel does not emit hardware in cpuinfo

They have no plans to add it either, so just hardcode AArch64.

5 months agoprivsep: Fix Linux i386 for SECCOMP as it just uses socketcall
Roy Marples [Sat, 12 Dec 2020 22:12:54 +0000 (22:12 +0000)]
privsep: Fix Linux i386 for SECCOMP as it just uses socketcall

Rather than accept(2), recv(2), etc..... which is horrible!

Thanks to Steve Hirsch <stevehirsch49@msn.com> for testing.

5 months agoDHCP6: Fix a LGTM issue
Roy Marples [Sat, 12 Dec 2020 17:41:37 +0000 (17:41 +0000)]
DHCP6: Fix a LGTM issue

5 months agoprivsep: Allow getsockopt for SO_RCVBUF on Linux
Roy Marples [Sat, 12 Dec 2020 17:35:45 +0000 (17:35 +0000)]
privsep: Allow getsockopt for SO_RCVBUF on Linux

For when the link socket overflows

5 months agolink: Report errors obtaining recv buffer size on link overflow
Roy Marples [Sat, 12 Dec 2020 17:34:31 +0000 (17:34 +0000)]
link: Report errors obtaining recv buffer size on link overflow

5 months agolink: Only report hardware address changes for active interfaces
Roy Marples [Sat, 12 Dec 2020 17:33:26 +0000 (17:33 +0000)]
link: Only report hardware address changes for active interfaces

5 months agoLinux: Support wireless IP roaming
Roy Marples [Sat, 12 Dec 2020 13:12:26 +0000 (13:12 +0000)]
Linux: Support wireless IP roaming

This is achieved by checking that the interface is wireless,
IFF_UP and IFF_LOWER_UP are present, but IFF_RUNNING is missing.

This gives exactly the same support as modern NetBSD when carrier
loss is detected, but without the address verifications when the
carrier comes back as that needs to be handled in the kernel.

While IP setup is maintained, other configuration data is discarded.
Note that this should be improved in the future.

Thanks to Boris Krasnovskiy <borkra@gmail.com> for helping with this.

5 months agoprivsep: Don't log a BPF error that network is down
Roy Marples [Wed, 9 Dec 2020 11:15:30 +0000 (11:15 +0000)]
privsep: Don't log a BPF error that network is down

The master process will catch this clean remove the BPF process.

5 months agoLinux: Fix privsep build by including sys/termios.h for all platforms
Mikhail Efremov [Tue, 8 Dec 2020 16:15:28 +0000 (16:15 +0000)]
Linux: Fix privsep build by including sys/termios.h for all platforms

5 months agoRelease dhcpcd-9.3.4 dhcpcd-9.3.4
Roy Marples [Sat, 28 Nov 2020 14:12:59 +0000 (14:12 +0000)]
Release dhcpcd-9.3.4

5 months agoDHCP6: Abort in test mode when an error is returned by server.
Roy Marples [Wed, 25 Nov 2020 15:14:11 +0000 (15:14 +0000)]
DHCP6: Abort in test mode when an error is returned by server.

5 months agoDon't stop control in test
Roy Marples [Wed, 25 Nov 2020 14:55:25 +0000 (14:55 +0000)]
Don't stop control in test

5 months agooptions: Allow duid to take a value
Roy Marples [Wed, 25 Nov 2020 14:19:55 +0000 (14:19 +0000)]
options: Allow duid to take a value

If a value is given, it overrides /var/db/dhcpcd/duid.

5 months agooptions: allow --ia_na=1 and --ia_pd=2 on the command line
Roy Marples [Wed, 25 Nov 2020 14:05:18 +0000 (14:05 +0000)]
options: allow --ia_na=1 and --ia_pd=2 on the command line

This only works for non master mode.

5 months agoDHCP: If error adding the address in oneshot, exit with failure
Roy Marples [Tue, 24 Nov 2020 10:30:08 +0000 (10:30 +0000)]
DHCP: If error adding the address in oneshot, exit with failure

Otherwise we loop.
It's unlikely oneshot would be used with IPv6 due to addresses
having lifetimes.

5 months agoDHCP: Only listen to the address if we successfully added it
Roy Marples [Mon, 23 Nov 2020 13:22:20 +0000 (13:22 +0000)]
DHCP: Only listen to the address if we successfully added it

Fixes an issue on Linux where the headers advertise something
newer than what the kernel actually provides.

5 months agoImprove readability.
Roy Marples [Sat, 21 Nov 2020 12:01:21 +0000 (12:01 +0000)]
Improve readability.

5 months agoDHCP6: Delegated activations work once more
Roy Marples [Sat, 21 Nov 2020 11:59:07 +0000 (11:59 +0000)]
DHCP6: Delegated activations work once more

This was broken with the --noconfigure option in dhcpcd-9.3.3

5 months agoDHCP6: Fix segfault introduced in dhcpcd-9.3.3
Roy Marples [Sat, 21 Nov 2020 08:46:30 +0000 (08:46 +0000)]
DHCP6: Fix segfault introduced in dhcpcd-9.3.3

lo0 won't have a configuration for example.

5 months agodhcpcd.conf(8): add all -> at all
Lars Wendler [Fri, 20 Nov 2020 19:49:46 +0000 (19:49 +0000)]
dhcpcd.conf(8): add all -> at all

5 months agoRelease dhcpcd-9.3.3 dhcpcd-9.3.3
Roy Marples [Fri, 20 Nov 2020 13:06:16 +0000 (13:06 +0000)]
Release dhcpcd-9.3.3

5 months agoprivsep: adjust comment for prior
Matthew Clarkson [Thu, 19 Nov 2020 19:15:12 +0000 (19:15 +0000)]
privsep: adjust comment for prior

Note that this is a requirement for printf over serial terminals.

5 months agoprivsep: Allow ioctl TCGETS
Matthew Clarkson [Thu, 19 Nov 2020 15:37:33 +0000 (15:37 +0000)]
privsep: Allow ioctl TCGETS

printf on some platforms seems to require it.
Without this, script_dump() may fault.

6 months agoprivsep: Allow fcntl64 and fstat64 to fix ARM32 talking to the controller
Matthew Clarkson [Fri, 13 Nov 2020 08:22:42 +0000 (08:22 +0000)]
privsep: Allow fcntl64 and fstat64 to fix ARM32 talking to the controller

We already allow fcntl and fstat so this is not a problem.