From: Roy Marples <roy@marples.name>
Date: Thu, 11 Sep 2014 10:48:49 +0000 (+0000)
Subject: Fix some clang analyzer warnings.
X-Git-Tag: dhcpcd-ui-0.7.0~26
X-Git-Url: https://roy.marples.name/git?ds=sidebyside

Fix some clang analyzer warnings.
---

diff --git a/src/libdhcpcd/config.c b/src/libdhcpcd/config.c
index d17fd0d..709a8e8 100644
--- a/src/libdhcpcd/config.c
+++ b/src/libdhcpcd/config.c
@@ -177,6 +177,7 @@ dhcpcd_config_set1(DHCPCD_OPTION **config, const char *opt, const char *val,
 			o = dhcpcd_option_new("static", t);
 		else
 			o = dhcpcd_option_new(opt, val);
+		free(t);
 		if (o == NULL)
 			return false;
 		if (l == NULL)
diff --git a/src/libdhcpcd/dhcpcd.c b/src/libdhcpcd/dhcpcd.c
index 8753934..919c8ff 100644
--- a/src/libdhcpcd/dhcpcd.c
+++ b/src/libdhcpcd/dhcpcd.c
@@ -803,9 +803,9 @@ dhcpcd_if_message(DHCPCD_IF *i, bool *new_msg)
 	if (showssid)
 		p += snprintf(p, len - (size_t)(p - msg), " %s", i->ssid);
 	if (iplen)
-		p += snprintf(p, len - (size_t)(p - msg), " %s/%s", ip, iplen);
+		snprintf(p, len - (size_t)(p - msg), " %s/%s", ip, iplen);
 	else if (ip)
-		p += snprintf(p, len - (size_t)(p - msg), " %s", ip);
+		snprintf(p, len - (size_t)(p - msg), " %s", ip);
 
 	if (new_msg) {
 		if (i->last_message == NULL || strcmp(i->last_message, msg))