dhcpcd-discuss

Re: log noise after upgrading from 9.3.2 to 9.4.0 on OpenBSD

Theo Buehler

Wed Jan 13 20:45:16 2021

I forgot to include the most important bit in my last mail: Thanks a lot
for dhcpcd! I'm a new user only a few months. It was easy to figure out
how to get it to do what I want it to and since then it has just worked.

Two small notes:

On Mon, Jan 11, 2021 at 06:11:03PM +0100, Theo Buehler wrote:
> After upgrading my router to OpenBSD-current and updating the dhcpcd
> package from dhcpcd-9.3.2v0 to 9.3.4v0, I started seeing a noise of this

Typo. I meant dhcpcd 9.4.0v0 when I wrote 9.3.4v0.

> 394         TAILQ_FOREACH(ifp2, ifp->ctx->ifaces, next) {
> 395                 if (!ifp2->active)
> 396                         continue;
> 397                 rt = rt_new(UNCONST(ifp2));
> 398                 if (rt == NULL)
> 399                         goto eexit;
> 400                 if (rb_tree_insert_node(&ifaces, rt) != rt)

If the insertion fails, shouldn't rt be freed with rt_free()?

> 401                         goto eexit;
> 402         }

Follow-Ups:
Re: log noise after upgrading from 9.3.2 to 9.4.0 on OpenBSDRoy Marples
References:
log noise after upgrading from 9.3.2 to 9.4.0 on OpenBSDTheo Buehler
Archive administrator: postmaster@marples.name