dhcpcd-discuss

Hi.

This is my first post to this list, so apologies if I leave out some
info that is generally expected. I'll happily provide more info if
needed.

After upgrading my router to OpenBSD-current and updating the dhcpcd
package from dhcpcd-9.3.2v0 to 9.3.4v0, I started seeing a noise of this
form in my logs:

Jan 11 13:43:57 apu dhcpcd[89340]: make_env: Undefined error: 0
Jan 11 13:43:57 apu dhcpcd[89340]: script_runreason: Undefined error: 0
Jan 11 13:46:44 apu dhcpcd[89340]: make_env: Undefined error: 0
Jan 11 13:46:44 apu dhcpcd[89340]: script_runreason: Undefined error: 0

Every 2-3 minutes such lines are added. Apart from the noise, everything
seems to be working as normal. Stuart Henderson tells me he's seeing the
same on one of his boxes.

The reason for the log messages is that the rb_tree_insert_node() check
on line 400 of script.c fails in my setup:

394         TAILQ_FOREACH(ifp2, ifp->ctx->ifaces, next) {
395                 if (!ifp2->active)
396                         continue;
397                 rt = rt_new(UNCONST(ifp2));
398                 if (rt == NULL)
399                         goto eexit;
400                 if (rb_tree_insert_node(&ifaces, rt) != rt)
401                         goto eexit;
402         }

Reverting the script.c part of the commit below (and the one that added
lines 395 and 396) makes the noise go away.

https://roy.marples.name/cgit/dhcpcd.git/commit/?id=217132b10a4841777c7296b1e5bca65b67b825be

My /etc/dhcpcd.conf is this:

ipv6only
noipv6rs
duid
persistent
option rapid_commit
require dhcp_server_identifier

script ""

allowinterfaces em0
interface em0
  ipv6rs
    ia_pd 1 em1/1 em2/2 athn0/3