dhcpcd-discuss

Re: [PATCH] Fix build on powerpc

Mikhail Efremov

Tue Dec 08 16:29:07 2020

On Tue, 8 Dec 2020 16:20:17 +0000 Roy Marples wrote:
> Hi Mikhail
> 
> On 08/12/2020 08:01, Mikhail Efremov wrote:
> > On powerpc struct termios must be defined for TCGETS macro.
> > ---
> >   src/privsep-linux.c | 5 +++++
> >   1 file changed, 5 insertions(+)
> > 
> > diff --git a/src/privsep-linux.c b/src/privsep-linux.c
> > index e588ecd7..b664f013 100644
> > --- a/src/privsep-linux.c
> > +++ b/src/privsep-linux.c
> > @@ -30,6 +30,11 @@
> >   #include <sys/prctl.h>
> >   #include <sys/syscall.h>
> >   
> > +/* For TCGETS on powerpc */
> > +#if defined(__powerpc64__) || defined(__powerpc__)
> > +#include <sys/termios.h>
> > +#endif
> > +
> >   #include <linux/audit.h>
> >   #include <linux/filter.h>
> >   #include <linux/seccomp.h>  
> 
> Fixed here:
> https://roy.marples.name/cgit/dhcpcd.git/commit/?id=e7c22336461ee345a5668eed6158e935cd4cdf1a
> 
> I decided to include it for all platforms just to be on the safe side.
> It's not a platform specific header so this is fine.

I think you are right. Thanks!

-- 
WBR, Mikhail Efremov

References:
[PATCH] Fix build on powerpcMikhail Efremov
Re: [PATCH] Fix build on powerpcRoy Marples
Archive administrator: postmaster@marples.name