dhcpcd-discuss

On 16/06/2020 16:23, Roy Marples wrote:
> Hi Ed
>
> On 16/06/2020 16:06, Ed W wrote:
> > Hi, the root issue here is this line:
> > https://github.com/rsmarples/dhcpcd/blob/709e6b1a38ef87ada75354e968a9b35eca3131aa/src/common.h#L75 
> >
> >
> > This prevents versions 8.x & 9.x compiling in uclibc-ng for example
> >
> > I've submitted a patch upstream to uclibc-ng that seems accepted for 
> > release ucblibc-ng-1.0.34, however, simply commenting out the 
> > #include also works for me...
> >
> > Up to you how you carry this forward? I guess it's useful to have 
> > older linux's work ok, but you might also consider renaming your 
> > "__unused" macro since that's what is tickling it? (the macro renames 
> > struct members in other .h files, triggering the compile error)
>
> There is a little history over the name of this macro.
> It was orginally just unused, but that clashed with a macro in some 
> linux ppc headers.
> So I renamed it to _unused.
> That then clashed with something in linux-3.7 headers.
> So I renamed it to __unused which co-incidently matched NetBSD define 
> for the same purpose.
>
> I think I'll leave it as it is for now.
> Thanks for supporting it in uclibc-ng though!
>
> Roy


I'm not arguing, just discussion: glibc went down the route of a 
namespace on the variable, like "__glibc_unused". I sent the approx same 
patch to uclibc with the same logic.

One suggestion in this case could be to call it "__dhcpc_unused" ?

Just thinking outloud? In any case the problem is resolved once this all 
shakes out I think (note I haven't tested your latest change on latest 
uclibc-ng, but presuming it's ok... )

Thanks for dhcpcd!

Ed W