dhcpcd-discuss

dhcpcd logging subsystem modification

Sergey Nikiforov

Mon Feb 10 08:44:56 2020

Hello everyone.


Here at Kaspersky we are using dhcpcd code pulled from NetBSD project and patched to work on KasperskyOS. There is, however, an issue with logging subsystem - we use our own which uses source code file name, line number etc. The obvious solution is to replace functions like "loginfox" with macros, but this can't be done without patching several tens of places where addresses of such functions are taken to choose logging level ("debug"/"info" etc).


Will you accept a patch which will rename "loginfox" and similar functions, add macros with old names ("loginfox" etc) calling renamed functions (to keep existing logging syntax but prevent their addresses being taken) and adjust no longer compilable places in code to use "logging level" parameter instead of function pointer? This way everyone who needs logging with __LINE__ and similar macros would not need to patch several tens of places in dhcpcd code.


If I would post this patch here and it would be accepted, it would get into NetBSDsource tree, am I right?


WBR,

Sergey Nikiforov, Kaspersky Developer



Follow-Ups:
Re: dhcpcd logging subsystem modificationRoy Marples
Archive administrator: postmaster@marples.name