dhcpcd-discuss

Re: Typo in wpa_supplicant hook

Roy Marples

Tue Jul 09 09:31:30 2019

On 08/07/2019 22:02, MK wrote:
Hi!

Dhcpcd is great, thanks and keep up the good work.

Thanks for the kind words :)


There's a typo in 10-wpa_supplicant -> wpa_supplicant_stop():

         err=$(wpa_cli -i"$interface" terminate 2>&1)
         errn=$?
         if [ $errn != 0 ]; then
                 syslog err "failed to start wpa_supplicant"
                                       ^^^^^

Looks like part of that was copy-pasted from supplicant_start(), and may confuse someone trying to debug some scenario.  It's present in the github repo and downstream in current
fedora and debian packages.

Fixed here:
https://roy.marples.name/cgit/dhcpcd.git/commit/?id=6839a551720b59ebfe7c4af94e395bcdcdde1d8a

But really, now that wpa_supplicant has the -M interface matching argument, this hook is no longer needed.

Roy

References:
Typo in wpa_supplicant hookMK
Archive administrator: postmaster@marples.name