dhcpcd-discuss

Re: [RFC]Routes are stored as a linked list

Roy Marples

Sun Mar 03 23:55:10 2019

On 03/03/2019 21:22, Roy Marples wrote:
I'll look into adding some portability gunk so this can compile on Linux at least, again, sometime next week. Probably before I look at the frrouting.

Gunk added.
Works on Linux - and valgrind reports no memory leaks.
I suspect the issue on your patch is the route comparison as I had to add some extra stuff there.

Works on FreeBSD as well, but segfaults on OpenBSD - I need to look into that.

Sadly I accidently had IPv4LL support compiled out, so the binary size is now sadly a growth of 1k and memory usage is marginally higher.

To save me some time, could you checkout the rbtree branch and test performance and memory usage with your thousands of routes please? Would be good to compare to the OpenBSD variant you did.

Thanks

Roy

Follow-Ups:
Re: [RFC]Routes are stored as a linked listDonald Sharp
References:
[RFC]Routes are stored as a linked listDonald Sharp
Re: [RFC]Routes are stored as a linked listRoy Marples
Re: [RFC]Routes are stored as a linked listDonald Sharp
Re: [RFC]Routes are stored as a linked listRoy Marples
Archive administrator: postmaster@marples.name