dhcpcd-discuss

Re: 7.x vs 6.x release - subdir Makefile failures don't stop top level iteration - failing the build.

Roy Marples

Thu Feb 14 21:26:08 2019

Hi Kenny

On 14/02/2019 18:25, Kenny Napier wrote:

   I am building dhcpcd as part of a larger system with a bitbake recipe.   I noticed with the 7.1.0 release a compile error

   does not bubble up so the whole build fails.

  The issue is at the top level make file where it attempts to invoke the subdir make files.  This is new

   for the 7.x releases.


    all: config.h

         for x in ${SUBDIRS}; do cd $$x; ${MAKE} $@; cd ..; done

   If the make part fails the 'cd..' always passes so it keeps going.

  For a workaround this works for me by invoking the exit on failure of the make step.

    all: config.h

         for x in ${SUBDIRS}; do cd $$x; ${MAKE} $@ || exit ; cd ..; done



Fixed here:
https://roy.marples.name/git/dhcpcd.git/commit/?id=72e45666105eaada29e622d537617c38ccb33acd

Thanks

Roy

References:
7.x vs 6.x release - subdir Makefile failures don't stop top level iteration - failing the build.Kenny Napier
Archive administrator: postmaster@marples.name