dhcpcd-discuss

Hi,

I include --disable-inet6 in the call to configure and as a result I get a number of warnings and a build error:

dhcpcd.c: In function 'dhcpcd_drop':
dhcpcd.c:401:2: warning: implicit declaration of function 'dhcp_drop'; did you mean 'dhcpcd_drop'?
[-Wimplicit-function-declaration]
  dhcp_drop(ifp, stop ? "STOP" : "EXPIRE");
  ^~~~~~~~~
  dhcpcd_drop
dhcpcd.c: In function 'dhcpcd_startinterface':
dhcpcd.c:969:4: warning: implicit declaration of function 'dhcp_start'; did you mean 'dev_start'?
[-Wimplicit-function-declaration]
    dhcp_start(ifp);
    ^~~~~~~~~~
    dev_start
dhcpcd.c: In function 'if_reboot':
dhcpcd.c:1223:2: warning: implicit declaration of function 'dhcp_reboot_newopts' [-Wimplicit-function-declaration]
  dhcp_reboot_newopts(ifp, oldopts);
  ^~~~~~~~~~~~~~~~~~~
dhcpcd.c: In function 'dhcpcd_ifrenew':
dhcpcd.c:1308:2: warning: implicit declaration of function 'dhcp_renew'; did you mean 'dhcpcd_ifrenew'?
[-Wimplicit-function-declaration]
  dhcp_renew(ifp);
  ^~~~~~~~~~
  dhcpcd_ifrenew
dhcpcd.c: In function 'dhcpcd_getinterfaces':
dhcpcd.c:1400:7: warning: implicit declaration of function 'D_STATE_RUNNING'; did you mean 'IPV4LL_STATE_RUNNING'?
[-Wimplicit-function-declaration]
   if (D_STATE_RUNNING(ifp))
       ^~~~~~~~~~~~~~~
       IPV4LL_STATE_RUNNING
dhcpcd.c: In function 'main':
dhcpcd.c:1726:4: warning: implicit declaration of function 'dhcp_printoptions'; did you mean 'if_printoptions'?
[-Wimplicit-function-declaration]
    dhcp_printoptions(&ctx,
    ^~~~~~~~~~~~~~~~~
    if_printoptions
dhcpcd.c:1867:8: warning: implicit declaration of function 'dhcp_dump'; did you mean 'dhcpcd_drop'?
[-Wimplicit-function-declaration]
    if (dhcp_dump(ifp) == -1)
        ^~~~~~~~~
        dhcpcd_drop

<snip>

cc -Wl,-export-dynamic -o dhcpcd common.o control.o dhcpcd.o duid.o eloop.o logerr.o if.o if-options.o sa.o route.o
dhcp-common.o script.o auth.o if-linux.o dhcp.o ipv4.o bpf.o arp.o ipv4ll.o dhcpcd-embedded.o dev.o
../compat/crypt/hmac.o ../compat/crypt/md5.o ../compat/crypt/sha256.o ../compat/arc4random.o
../compat/arc4random_uniform.o ../compat/strlcpy.o ../compat/pidfile.o ../compat/strtoi.o ../compat/strtou.o -ldl
dhcpcd.c:1400: error: undefined reference to 'D_STATE_RUNNING'
collect2: error: ld returned 1 exit status

The patch below fixes all these.

--- dhcpcd-7.1.1/src/dhcpcd.c.orig	2019-02-08 12:05:34.292390258 +0000
+++ dhcpcd-7.1.1/src/dhcpcd.c	2019-02-08 12:05:52.540390708 +0000
@@ -53,6 +53,7 @@ const char dhcpcd_copyright[] = "Copyrig
 #include "control.h"
 #include "dev.h"
 #include "dhcp-common.h"
+#include "dhcp.h"
 #include "dhcpcd.h"
 #include "dhcp6.h"
 #include "duid.h"


Chris