dhcpcd-7.0.8 Coverity detected defect - Logically dead code (DEADCODE)
Shahid Mahmood
Mon Sep 10 17:45:14 2018
Hi Roy,
Our coverity analysis reported the following defect. Just so you know:
63static size_t
64duid_machineuuid(char *uuid, size_t uuid_len)
65{
66 int r;
67 size_t len = uuid_len;
....
85 if (fgets(uuid, (int)uuid_len, fp) == NULL) {
86 fclose(fp);
87 return 0;
88 }
89 len = strlen(uuid) + 1;
90 fclose(fp);
[Coverity]assignment: Assigning: r = 0.
91 r = 0;
92#else
93 r = -1;
94 errno = ENOSYS;
95#endif
96
[Coverity] const: At condition r == -1, the value of r must be equal to 0.
[Coverity] dead_error_condition: The condition r == -1 cannot be true.
97 if (r == -1)
[Coverity] Logically dead code (DEADCODE)dead_error_line: Execution cannot
reach this statement: return 0U;.
98 return 0;
99 return len;
100}
Regards,
-shahid
Archive administrator: postmaster@marples.name