dhcpcd-discuss

On 04/10/2017 00:07, Roy Marples wrote:
> > At top level:
> > if-linux.c:107:22: warning: ‘ipv4_bcast_addr’ defined but not used 
> > [-Wunused-const-variable=]
> >   static const uint8_t ipv4_bcast_addr[] = {
>
> Can fix this

https://roy.marples.name/git/dhcpcd.git/commit/?id=b5f2b924ae40eb606176bfcab1c086d7c355799c

> > f) src/dhcp6.c
> > dhcp6.c: In function ‘dhcp6_bind’:
> > dhcp6.c:2948:21: warning: comparison between signed and unsigned 
> > integer expressions [-Wsign-compare]
> >      if (state->renew > diff.tv_sec)
> >                       ^
> > dhcp6.c:2954:22: warning: comparison between signed and unsigned 
> > integer expressions [-Wsign-compare]
> >      if (state->rebind > diff.tv_sec)
> >                        ^
> > dhcp6.c:2960:22: warning: comparison between signed and unsigned 
> > integer expressions [-Wsign-compare]
> >      if (state->expire > diff.tv_sec)
>
> Can probably fix this.

https://roy.marples.name/git/dhcpcd.git/commit/?id=5e2811aa5a2f7883960be1606b7016132550c21b

> > g) compat/crypt/md5.c/.h
> > In file included from ../compat/crypt/md5.c:23:0:
> > ../compat/crypt/md5.c: In function ‘MD5Final’:
> > ../compat/crypt/md5.h:22:26: warning: conversion to ‘size_t {aka 
> > unsigned int}’ from ‘uint64_t {aka long long unsigned int}’ may alter 
> > its value [-Wconversion]
> >   #define MD5_BLOCK_LENGTH 64
> >                            ^
> > ../compat/crypt/md5.c:228:11: note: in expansion of macro 
> > ‘MD5_BLOCK_LENGTH’
> >    padlen = MD5_BLOCK_LENGTH -
> >             ^~~~~~~~~~~~~~~~
>
> Can probably fix this.

https://roy.marples.name/git/dhcpcd.git/commit/?id=121de3ede63f69ad52331310478acf986cfaedd2

Not sure the others are strictly dhcpcd compile issues.

Roy