dhcpcd-discuss

Re: Remotely exploitable crash in dhcpcd

Jason A. Donenfeld

Sun Jun 25 16:39:50 2017

Hi Roy,

On Sat, Jun 24, 2017 at 3:23 PM, Roy Marples <roy@xxxxxxxxxxxx> wrote:
> Can you test this patch? This restores the dhcpcd-6, check but should have
> the same effect.
> https://dev.marples.name/D121

I can confirm this fixes the segfault.

Do note, though, that the IP-swapping feature we've been discussing is
still broken. Test case:

- eth0 is metric 200
- wlan0 is metric 300
- set eth0 up --> eth0 gets 10.10.10.100
- set wlan0 up --> wlan0 gets nothing
- unplug eth0 --> wlan0 gets reassigned 10.10.10.100
- plug eth0 --> eth0 gets nothing

Not giving the IP back to eth0 is problematic, since eth0 has the
lower metric. More generally, the other approach we've discussed on
this thread -- of giving both interfaces the address simultaneous so
that the ordinary metric in the routing table can handle things -- is
much preferable.

Regards,
Jason

References:
Remotely exploitable crash in dhcpcdJason A. Donenfeld
Re: Remotely exploitable crash in dhcpcdRoy Marples
Archive administrator: postmaster@marples.name