Re: Arping Bug
Roy Marples
Tue Dec 13 20:43:14 2016Hi Piers On 12/12/16 17:48, Piers O'Hanlon wrote: > Hi Roy, > > Thanks for your previous explanation about the arping operation - simultaneous ARPINGs would be a nice speed improvement… Welcome :) File a ticket for the new feature please as I'm very time constrained for large-ish things right now. > > It seems there appears to be a problem with your fix for ARPING - I think one needs to add the same check (state->arping_index != -1) used in dhcp_arp_conflicted() to the arping checks (e.g. state->arping_index != -1 && state->arping_index < ifo->arping_len) in both dhcp_start1() and dhcp_probed() otherwise ARPING start sending ARPs when there are no arping entries. Fixed here: http://roy.marples.name/projects/dhcpcd/ci/1642d0026e7d4e11?sbs=0 Let me know how it works for you. Roy
Attachment:
signature.asc
Description: OpenPGP digital signature
| Arping Bug | Piers O'Hanlon |
| Re: Arping Bug | Roy Marples |
| Re: Arping Bug | Piers O'Hanlon |
| Re: Arping Bug | Piers O'Hanlon |
| Re: Arping Bug | Roy Marples |
| Re: Arping Bug | Piers O'Hanlon |
| Re: Arping Bug | Roy Marples |
| Re: Arping Bug | Piers O'Hanlon |