dhcpcd-discuss

On 06/12/16 15:58, Piers O'Hanlon wrote:
> Thanks - That seems to run fine on my systems - it looks like a good
> fix.

Yay :)
http://roy.marples.name/projects/dhcpcd/ci/5a3bbc20da475fe2?sbs=0

> 
> One thing that may still be awry is the check in
> dhcp_arp_conflicted() only for the previous address in the arping
> array (amsg->sip.s_addr == ifo->arping[state->arping_index]) - it
> seems that if there if there are multiple arping entries then it
> might miss a matching address from one of the preceding arping
> queries?

The dhcp state only handled one ARPing at a time so this is fine.
If we allow it to ping everything at once then it introduces a race
condition where the faster host to reply wins if >1 host on the network.
Still, this might be a good thing I guess in some cases.

Anyone else here have any thoughts on this as a speed boost?

Roy

Attachment: signature.asc
Description: OpenPGP digital signature