dhcpcd-discuss

Thanks - That seems to run fine on my systems - it looks like a good fix.

One thing that may still be awry is the check in dhcp_arp_conflicted() only for the previous address in the arping array (amsg->sip.s_addr == ifo->arping[state->arping_index]) - it seems that if there if there are multiple arping entries then it might miss a matching address from one of the preceding arping queries?

Best,

Piers

> On 5 Dec 2016, at 20:46, Roy Marples <roy@xxxxxxxxxxxx> wrote:
> 
> Hi Peter
> 
> On 05/12/16 15:39, Piers O'Hanlon wrote:
>> It seems that there’s still issues with my fix below as
>> dhcp_arp_probed() then fails to function normally, as does
>> dhcp_arp_conflicted(). So one could add state->arping_index++  just
>> before dhcpcd_startinterface() is called in both functions.
> 
> Yes :)
> 
> I've found some time to do some testing have made the attached patch
> which appears to work fine for me and passed valgrind testing.
> Can you verify it fixes the issue for you please?
> 
> Thanks
> 
> Roy
> <dhcpcd-arping.patch>

Attachment: signature.asc
Description: Message signed with OpenPGP using GPGMail