dhcpcd-discuss

Arping Bug

Piers O'Hanlon

Wed Nov 30 14:02:55 2016

Hi,

I’ve been looking at the dhcpcd codebase and I appear to have come across a bug: The code in dhcp.c is currently skipping the last or only arping entry as it increments the index counter before sending the ARP Probe out (from Artifact d0ced6943d15bffcd8415b37d092504dc1e923f1):
dhcp.c:1997   		if (++state->arping_index < ifo->arping_len) {
The fix appears to be simple (unless I’m missing something):
dhcp.c:1997   		if (state->arping_index++ < ifo->arping_len) {

Cheers,

Piers



Follow-Ups:
Re: Arping BugRoy Marples
Archive administrator: postmaster@marples.name