dhcpcd-discuss

Hello

Thank you for your encouraged responses!
I am glad to know dhcpcd starts to use Coverity tool which is one of
famous code analysis tool.

Comments inline.

> Thanks for your kind words, and I'm glad you find my software of use!

We appreciate dhcpcd open source software communities and respect to you.

> > # 0001-double-free-possibility-is-fixed.patch
> 
> This has already been fixed:
> http://roy.marples.name/projects/dhcpcd/info/ad143ddb5be476a1

I confirmed L2014 and L2046. This has more fixed issue.
Thank your for your kindness explanation one by one.

> 
> > # 0002-A-resource-leak-issue-is-fixed.patch
> 
> This has already been fixed:
> http://roy.marples.name/projects/dhcpcd/info/644bd663b5d5222e
> 
I confirmed L599 to L601.

> > # 0003-A-resource-leak-issue-is-fixed.patch
> 
> Already fixed in unrelated changes:
> http://roy.marples.name/projects/dhcpcd/info/5c05b6a9aeac85d8
> http://roy.marples.name/projects/dhcpcd/info/8e353e95ef5e0c59
> 
I confirmed these satisfied my indication.


> > # 0004-A-resource-leak-issue-is-fixed.patch
> 
> Applied with changes for another leak in the same code here:
> http://roy.marples.name/projects/dhcpcd/info/337b4815991aaa75
> 
> I've not tested building without an embedded config so I'll submit some
> Coverity builds for it soon.
>
I confirmed L2343 is applied. In addition, thank you for fixing more about
the realloc problem by adding "char *nbuf" (L2350). That's fine.


> > # 0005-A-resource-leak-issue-is-fixed.patch
> 
> Already fixed here:
> http://roy.marples.name/projects/dhcpcd/info/84e7ec7449621b52
> Although I just made this change so that the logged error isn't affected
> by the free call, so it now mirrors your initial change.
> http://roy.marples.name/projects/dhcpcd/info/9bc41b7867a37f80
> 
I confirmed L1140 for the first link.
I understand your meaning for the second link. It's also fine.


> > # 0006-A-resource-leak-issue-is-fixed.patch
> 
> Already fixed here:
> http://roy.marples.name/projects/dhcpcd/info/b1b5127314de9eb0
> http://roy.marples.name/projects/dhcpcd/info/dfa1b8fec4a821bf
> 
I confirmed these two modification achieved to fix my indicated issue.

> 
> You should note that dhcpcd-6.11.0 fixed a lot of issues similar to these
> as found by Coverity as that's the first version where I started using this
> serivce. dhcpcd-6.11.1 then fixed a few issues with those fixes ;)
I agree to your recommendation. I try to use dhcpcd-6.11.1.

Thanks and Best Regards,
Koichi Okamoto