dhcpcd-discuss

Hi

On 21/07/2016 07:38, Okamoto, Koichi wrote:
> Nice to meet you via e-mail. I am Koichi Okamoto, senior system 
> engineer, to work for SONY Video & Sound Products Inc. in Tokyo.
> 
> Thank you for your dhcpcd open source software and for your 
> maintenance continuously!

Thanks for your kind words, and I'm glad you find my software of use!

> I'd like to inform you of my patch to fix some resources leak 
> issues.
> 
> If you can agree to these solutions, I hope you could apply this 
> patch for dhcpcd main branch.

Comments inline.

> Please note that these patches are created for dhcpcd-6.9.2 version 
> (older version, sorry). Only 
> "0006-A-resource-leak-issue-is-fixed.patch" may be able to use for 
> latest version.
> 
> I wish this patch may contribute a little for your dhcpcd open source
> software confidence.
> 
> Could you please see the purpose of these six patches one by one as
> follows:
> 
> # 0001-double-free-possibility-is-fixed.patch

This has already been fixed:
http://roy.marples.name/projects/dhcpcd/info/ad143ddb5be476a1

> # 0002-A-resource-leak-issue-is-fixed.patch

This has already been fixed:
http://roy.marples.name/projects/dhcpcd/info/644bd663b5d5222e

> # 0003-A-resource-leak-issue-is-fixed.patch

Already fixed in unrelated changes:
http://roy.marples.name/projects/dhcpcd/info/5c05b6a9aeac85d8
http://roy.marples.name/projects/dhcpcd/info/8e353e95ef5e0c59

> # 0004-A-resource-leak-issue-is-fixed.patch

Applied with changes for another leak in the same code here:
http://roy.marples.name/projects/dhcpcd/info/337b4815991aaa75

I've not tested building without an embedded config so I'll submit some
Coverity builds for it soon.

> # 0005-A-resource-leak-issue-is-fixed.patch

Already fixed here:
http://roy.marples.name/projects/dhcpcd/info/84e7ec7449621b52
Although I just made this change so that the logged error isn't affected
by the free call, so it now mirrors your initial change.
http://roy.marples.name/projects/dhcpcd/info/9bc41b7867a37f80

> # 0006-A-resource-leak-issue-is-fixed.patch

Already fixed here:
http://roy.marples.name/projects/dhcpcd/info/b1b5127314de9eb0
http://roy.marples.name/projects/dhcpcd/info/dfa1b8fec4a821bf


You should note that dhcpcd-6.11.0 fixed a lot of issues similar to
these as found by Coverity as that's the first version where I started
using this serivce. dhcpcd-6.11.1 then fixed a few issues with those
fixes ;)

Thanks!