dhcpcd-discuss

On 29/05/2014 11:38, Jouke Witteveen wrote:
> After a quick inspection I only see a possible issue with
>
> - char pidfile[sizeof(PIDFILE) + IF_NAMESIZE];
> + char pidfile[sizeof(PIDFILE) + IF_NAMESIZE + 1];
>
> You probably want "+ 2", as you also write a dash. The rest looks good 
> to me.

It's just a bit of extra safety really if the interface name is max 
length.
As %s is the equivalent of -4 (both 2 chars) it's fine.

Roy