Re: Enable promote_secondaries conditionally
Leonid Isaev
Sat May 03 19:00:55 2014Hi Roy, On Sat, 03 May 2014 11:19:26 +0100 Roy Marples <roy@xxxxxxxxxxxx> wrote: > On 02/05/2014 21:16, Leonid Isaev wrote: > > Hi, > > > > Currently dhcpcd attempts to set promote_secondaries to 1 (in > > if-linux.c, if_init()), and fails if /proc/sys if mounted ro. Hence, > > dhcpcd > > will not work in systemd-nspawn containers which mount /proc/sys ro. > > I understand why multiple IP addresses are useful, but perhaps > > if_init() should check whether promote_secondaries == 0 and write to it > > only > > in this case? > > I can't argue with that logic. > > Fixed here: > http://roy.marples.name/projects/dhcpcd/fdiff?v1=0ef160bc736bfd45&v2=1685c4313c847b3f&sbs=0 Awesome! Thanks a lot. L. -- Leonid Isaev GPG fingerprints: DA92 034D B4A8 EC51 7EA6 20DF 9291 EE8A 043C B8C4 C0DF 20D0 C075 C3F1 E1BE 775A A7AE F6CB 164B 5A6D
Attachment:
signature.asc
Description: PGP signature
| Enable promote_secondaries conditionally | Leonid Isaev |
| Re: Enable promote_secondaries conditionally | Roy Marples |