dhcpcd-discuss

On 22/02/2014 11:38, Roy Marples wrote:
> > I have attached a patch fixing those issues. Obviously, I'm not sure
> > if what i have done won't break something on other setups, since I
> > don't have a deep understanding of how the code works...
> >
> > With this patch, arping profiles work as expected on my setup, falling
> > through to dynamic address assignment if no matching profile could be
> > found.
>
> Thanks for the analysis.
> Your initial assumption about the problem looks correct, however the
> patch is wrong.
> The error itself is not advancing to the next arpping test when we
> have a matching address but not a matching profile.
> There is a secondary error which you picked up on with the possibility
> of a NULL options being passed to finish_config which I've fixed in a
> better way.
>
> Please test and report back. I won't have time to test extensively
> until next week maybe.

I've done some testing and there was an off by one error in my patch.
Here's a tested version which I've comitted:
http://roy.marples.name/projects/dhcpcd/ci/6cac8f0d57?sbs=0

Thanks

Roy