dhcpcd-discuss

On 28/11/2013 7:46, Brian De Wolf wrote:
> Adding IA_PD suffix support seemed like a fun spare time activity, so I
> whipped something up.  I wasn't sure where to submit to, so it's just
> in a commit on github for now:
>
> https://github.com/bldewolf/dhcpcd/commit/c6ab85de3954c019a9cec2ea32c155f4a6f64b2b
>
> Any comments?

Well, I don't know how to setup my git repo to accept stuff on a public 
non master branch.
Normally patches are posted here and we'll discuss them.
Ayway, I commented on github but I'll repost here also.

+  case O_IA_PD_SUFFIX:
+    free(ifo->ia_suffix);
+    ifo->ia_suffix = malloc(sizeof(*ifo->ia_suffix));

You need to check malloc here as the call could have failed.

While I'm happy with the idea, I dislike the approach because this would 
also affect creating SLAAC addresses from the RA.

Thanks

Roy