Re: [PATCH] always log from ip
Roy Marples
Fri Apr 30 18:23:50 2010On Fri, 2010-04-30 at 13:35 +0200, Gerd v. Egidy wrote: > > Also, we could simply the code by putting from into addr if we do not > > have a server id. > > I'm not sure if that would be a good idea. Because we only know from whom the > udp packet came to us, but not where exactly the real server is. The server > could easily be behind a dhcp forwarder. So there is a semantic difference. > > We could even clarify this by writing "via" instead of "from" in the log when > using the packet source ip instead of the DHO_SERVERID option. > > So I'd prefer to keep it as it is or even change the logging to via. I've pushed a change that keeps my optimisation, but changes from to via when serverid is not present. Thanks Roy
Attachment:
signature.asc
Description: This is a digitally signed message part
| [PATCH] always log from ip | Gerd v. Egidy |
| Re: [PATCH] always log from ip | Roy Marples |
| Re: [PATCH] always log from ip | Gerd v. Egidy |