dhcpcd-discuss

Re: [PATCH] always log from ip

Gerd v. Egidy

Fri Apr 30 11:35:44 2010

Hi Roy,

thanks for applying my patches.

> Also, we could simply the code by putting from into addr if we do not
> have a server id.

I'm not sure if that would be a good idea. Because we only know from whom the 
udp packet came to us, but not where exactly the real server is. The server 
could easily be behind a dhcp forwarder. So there is a semantic difference.

We could even clarify this by writing "via" instead of "from" in the log when 
using the packet source ip instead of the DHO_SERVERID option.

So I'd prefer to keep it as it is or even change the logging to via.

Kind regards,

Gerd

-- 
Address (better: trap) for people I really don't want to get mail from:
jonas@xxxxxxxxxxxxxxxxx

Follow-Ups:
Re: [PATCH] always log from ipRoy Marples
References:
[PATCH] always log from ipGerd v. Egidy
Re: [PATCH] always log from ipRoy Marples
Archive administrator: postmaster@marples.name